RequiredPtr: Fix template conditional for MSVC#114222
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 21, 2025
Merged
RequiredPtr: Fix template conditional for MSVC#114222akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
dsnopek
approved these changes
Dec 19, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
The code change seems fine.
We use the same trick in a whole bunch of other places in this class, but not all of them. For example, if you look up at the constructors that take T_Other, we're not doing it there.
So, I'm pretty unclear on when it's required and when it isn't, and since I haven't tested on MSVC myself, there's the possibility that more of these will need to be changed?
Member
Author
|
Yeah I have no clue either why this is needed in some cases and apparently not all. We could defensively use |
Ivorforce
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114206.
I'm not familiar with this syntax but a quick search on the error yielded https://stackoverflow.com/a/71512930, and that seems to solve it for @isaaccp.
I have no idea why MSVC on our CI doesn't have a problem though.